Refactor ResponseParser

package.json

 {
   "name": "zimbra-admin-api-js",
-  "version": "0.0.21",
+  "version": "0.0.22",
   "private": true,
   "main": "lib/zimbra-admin-api.js",
   "dependencies": {

src/utils/response_parser.js

+// Copyright (c) 2016 ZBox, Spa. All Rights Reserved.
+// See LICENSE.txt for license information.
+
+import Dictionary from './dictionary.js';
+import Error from '../zimbra/error.js';
+
+export default class ResponseParser {
+
+  static dictionary() {
+    return new Dictionary();
+  }
+
+  static allResponse(data, request_data, callback){
+    const resource = request_data.resource.toLowerCase();
+    const response_name = ResponseParser.dictionary().resourceResponseName(resource);
+    const response_object = data.get()[request_data.response_name][response_name];
+    const response_array = [];
+    if (response_object) response_object.forEach((r) => {
+      let element = ResponseParser.dictionary().classFactory(resource, r, request_data.client);
+      response_array.push(element);
+    });
+    return callback(null, response_array);
+  }
+
+  static batchResponse(data, callback) {
+    const response_object = data.options.response.BatchResponse;
+    return callback(null, response_object);
+  }
+
+  static countAccountResponse(data, request_data, callback) {
+    const coses = data.get().CountAccountResponse.cos;
+    const result = ResponseParser.dictionary().cosesToCountAccountObject(coses);
+    return callback(null, result);
+  }
+
+  // For requests that returns empty Object when Success
+  static emptyResponse(data, request_data, callback){
+    const response_object = data.get()[request_data.response_name];
+    return callback(null, response_object);
+  }
+
+  static getMailboxResponse (data, _, callback) {
+    const response_object = data.get().GetMailboxResponse.mbox[0];
+    const result = {
+      mbxid: response_object.mbxid,
+      account_id: response_object.id,
+      size: response_object.s
+    };
+    return callback(null, result);
+  }
+
+  static getResponse(data, request_data, callback) {
+    const resource = request_data.resource.toLowerCase();
+    const response_name = ResponseParser.dictionary().resourceResponseName(resource);
+    const response_object = data.get()[request_data.response_name][response_name][0];
+    const result = ResponseParser.dictionary().classFactory(resource, response_object, request_data.client);
+    return callback(null, result);
+  }
+
+  static grantsResponse(data, request_data, callback) {
+    const result = {};
+    const response_object = data.get().GetGrantsResponse;
+    return callback(null, response_object);
+  }
+
+  static searchResponse(data, request_data, callback) {
+    const response_types = ResponseParser.dictionary().searchResponseTypes();
+    const response_object = data.get()[request_data.response_name];
+    const result = { total: response_object.searchTotal, more: response_object.more };
+    response_types.forEach((type) => {
+      const resources = [];
+      if (typeof response_object[type] !== 'undefined') {
+        response_object[type].forEach((resource) => {
+          const object = ResponseParser.dictionary().classFactory(type, resource, request_data.client);
+          resources.push(object);
+        });
+        result[type] = resources;
+      }
+    });
+    return callback(null, result);
+  }
+
+  static setPasswordResponse(data, _, callback){
+    const response_object = data.response[0].SetPasswordResponse;
+    if (response_object.message) {
+      const err = {
+        status: 500,
+        statusText: response_object.message[0]._content,
+        responseJSON: {}
+      };
+      return callback(new Error(err));
+    } else {
+      return callback(null, {});
+    }
+  }
+
+}

src/zimbra/error.js

+// Copyright (c) 2016 ZBox, Spa. All Rights Reserved.
+// See LICENSE.txt for license information.
+
+export default class Error {
+  constructor(err) {
+    this.code = err.Fault ? err.Fault.Code.Value : err.status;
+    this.extra = this.getErrorInfo(err);
+  }
+
+  getErrorInfo(err) {
+    if (err && err.Fault) {
+      return {
+        'code': err.Fault.Detail.Error.Code,
+        'reason': err.Fault.Reason.Text,
+        'trace': err.Fault.Detail.Error.Trace
+      };
+    } else {
+      return { 'code': err.status, 'reason': err.statusText };
+    }
+  }
+}

test/js/spec/test.js

@@ -182,7 +182,6 @@
         if (err) return console.log(err);
         expect(data.attrs.sn).to.equal('Bruna');
         expect(data.attrs.givenName).to.equal('Patricio');
-        console.log(data);
         done();
       });
     });