Rename domain.admins() to domain.getAdmins()

README.md

@@ -323,6 +323,6 @@ Return an Array of the Domain Admins `Accounts`.
 
 ```javascript
 // domain is a Domain, you got it from zimbraApi.getDomain....
-domain.admins(callback);
+domain.getAdmins(callback);
 // [Account, Account]
 ```

TODOS.md

@@ -6,6 +6,7 @@
 ## Accounts
 
 * [ ] Que Dominios administra una cuenta
+* [ ] Espacio usado
 
 ## DistributionList
 
@@ -18,7 +19,7 @@
 * [ ] Devolver Tipo de renovación
 * [ ] Devolver Fecha de la proxima renovación
 * [ ] Devolver Empresa (esto entiendo necesitamos otro API)
-* [ ] Devolver Admins del dominio
+* [X] Devolver Admins del dominio
 * [ ] Devolver Listas de distribución del dominio
 
 ## parseResponse Class?

src/index.js

@@ -468,6 +468,22 @@ export default class ZimbraAdminApi {
     this.performRequest(request_data);
   }
 
+  setPassword(zimbra_id, password, callback) {
+    const request_data = { };
+    request_data.params = this.buildRequest();
+    request_data.request_name = "SetPassword";
+    request_data.params.name = `${request_data.request_name}Request`;
+    request_data.params.params = {
+      id: zimbra_id,
+      newPassword: password
+    };
+    request_data.callback = callback;
+    const that = this;
+    request_data.parse_response = function(data, _, callback){
+      return callback(null, data.response[0].SetPasswordResponse);
+    };
+    this.performRequest(request_data);
+  }
 
 }
 

src/zimbra/account.js

@@ -19,4 +19,8 @@ export default class Account extends Zimbra {
       }
     }
 
+    // setPassword(password, callback) {
+    //   this.api.setPassword(this.id, password, callback);
+    // }
+
 }

src/zimbra/domain.js

@@ -10,11 +10,11 @@ export default class Domain extends Zimbra {
   }
 
   // TODO: Fix this fucking ugly code
-  admins(callback) {
+  getAdmins(callback) {
     const that = this;
     this.getAdminsIdsFromGrants(function(e,d){
       if (e) return callback(e);
-      if (d.length < 1) return [];
+      if (d.length < 1) return callback(null, []);
       let query = "(|";
       d.forEach((id) => {
         const zimbra_id = `(zimbraId=${id})`;
@@ -24,7 +24,7 @@ export default class Domain extends Zimbra {
       that.api.getAllAccounts(function(e,d){
         if (e) return callback(e);
         if (d.total > 0) return callback(null, d.account);
-        callback(null, []);
+        return callback(null, []);
       }, {query: query});
     });
   }

test/js/spec/test.js

@@ -236,6 +236,19 @@
       });
     });
 
+    it('should set password', function(done){
+      let api = new ZimbraAdminApi(auth_data);
+      api.getAccount('pbruna@itlinux.cl', function(err, data){
+        let account = data;
+        account.setPassword('12345678910', function(err, data){
+          if (err) return console.log(err);
+          console.log(data);
+          done();
+        });
+      });
+    });
+
+
   });
 
   describe('Domain tests', function() {
@@ -345,7 +358,7 @@
       api.getDomain('customer.dev', function(err, data){
         if (err) console.error(err);
         let domain = data;
-        domain.admins(function(e, d){
+        domain.getAdmins(function(e, d){
           expect(d.length).to.be.above(1);
           expect(d[0].constructor.name).to.be.equal('Account');
           done();
@@ -358,7 +371,8 @@
       api.getDomain('zboxapp.dev', function(err, data){
         if (err) console.error(err);
         let domain = data;
-        domain.admins(function(e, d){
+        domain.getAdmins(function(e, d){
+          if (e) return console.log(e);
           expect(d.length).to.be.empty;
           done();
         });