Commit bc6eb4cb authored by Patricio Bruna's avatar Patricio Bruna

Fixed countAccounts for empty Domains

parent 622333c6
...@@ -314,3 +314,5 @@ domain.countAccounts(callback); ...@@ -314,3 +314,5 @@ domain.countAccounts(callback);
// } // }
} }
``` ```
If the `Domain` is empty, no 'Accounts', the result will be a `{}`.
...@@ -217,14 +217,12 @@ return /******/ (function(modules) { // webpackBootstrap ...@@ -217,14 +217,12 @@ return /******/ (function(modules) { // webpackBootstrap
value: function parseCountAccountResponse(data, request_data, callback) { value: function parseCountAccountResponse(data, request_data, callback) {
var result = {}; var result = {};
var coses = data.get().CountAccountResponse.cos; var coses = data.get().CountAccountResponse.cos;
coses.forEach(function (cos) { if (typeof coses !== 'undefined') coses.forEach(function (cos) {
result[cos.name] = { result[cos.name] = {
used: parseInt(cos._content), used: parseInt(cos._content),
id: cos.id id: cos.id
}; };
}); });
// const counts = Object.values(result);
// result.total = counts.reduce((a,b) => {return(a+b);});
return callback(null, result); return callback(null, result);
} }
}, { }, {
This diff is collapsed.
{ {
"name": "zimbra-admin-api-js", "name": "zimbra-admin-api-js",
"version": "0.0.9", "version": "0.0.10",
"private": true, "private": true,
"main": "lib/zimbra-admin-api.js", "main": "lib/zimbra-admin-api.js",
"dependencies": { "dependencies": {
......
...@@ -123,16 +123,13 @@ export default class ZimbraAdminApi { ...@@ -123,16 +123,13 @@ export default class ZimbraAdminApi {
parseCountAccountResponse(data, request_data, callback) { parseCountAccountResponse(data, request_data, callback) {
const result = {}; const result = {};
const coses = data.get().CountAccountResponse.cos; const coses = data.get().CountAccountResponse.cos;
coses.forEach((cos) => { if (typeof coses !== 'undefined') coses.forEach((cos) => {
result[cos.name] = { result[cos.name] = {
used: parseInt(cos._content), used: parseInt(cos._content),
id: cos.id id: cos.id
} }
}); });
// const counts = Object.values(result);
// result.total = counts.reduce((a,b) => {return(a+b);});
return callback(null, result); return callback(null, result);
} }
parseResponse(data, request_data, callback) { parseResponse(data, request_data, callback) {
......
...@@ -332,6 +332,15 @@ ...@@ -332,6 +332,15 @@
}); });
}); });
it('countAccounts hould return {} for empty Domain', function(done){
let api = new ZimbraAdminApi(auth_data);
api.countAccounts('juanitalapoderosa.com', function(err, data){
if (err) console.error(err);
expect(data).to.be.empty;
done();
});
});
it('domain.countAccounts() should return the counts', function(done){ it('domain.countAccounts() should return the counts', function(done){
let api = new ZimbraAdminApi(auth_data); let api = new ZimbraAdminApi(auth_data);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment